Remove deprecated code #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
force-pushed
the
ob-remove-deprecated-stuff
branch
from
4d19fe2 to
fe36d08
Compare
| @@ -1,344 +0,0 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Geeze, I didn't even know this was a thing.
|
Amazing that you've been keeping track of all these little inconsistencies all along. Nice! LGTM. |
Haha, tbh I mostly grep'd for "deprec", "warnings", "TODO", etc. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
Cleanup for version 2.0:
bin/stripeclientAPIRequestorall()method for list requests (the proper method islist())Customerapi_versionargument inEphemeralKey.create()(the proper argument isstripe_version)delete()method inSource(the proper method isdetach())delete_discount()methods inCustomerandSubscription. Instead, support sending params to the API. (Those methods currently don't take accept any parameters, but generally the library doesn't try to enforce which methods support parameters and which don't. Invalid arguments will be declined server-side.)StripeObject.to_dict(). The method is trivial, might as well keep supporting it.stripenamespace. Invididual exception classes are no longer imported directly in the global namespaces, as well as other internal classes and methods.